[Bugfix] Use TCP liveness probe for LMCache server - #1058
Draft
EltonChang1 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Elton Chang <tchang52@ucsc.edu>
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the cache server's liveness probe by replacing the Python-based exec probe with a TCP socket probe on the container port. These changes are applied to the Helm deployment template, updated in the test suite, and documented in the README. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1057
What changed
cacheserverSpec.containerPortWhy
The current LMCache image does not contain the referenced
health_probe.pyscript. The cache server exposes a TCP protocol, not an HTTP health endpoint, so probing its listening socket avoids restart loops caused by an image-specific script path.Validation
helm lint helmtcpSocket.port: 8000helm/README.mdgit diff --checkandgit show --check HEADLimitations
The full Helm unit suite reported 142 passing tests and two unrelated failures in the existing chat-template and RayCluster suites under the local Helm/plugin versions. No live Kubernetes or LMCache image test was run.
This draft was prepared with AI assistance and has not yet been human-reviewed.