[Feat] Support command and args on servingEngineSpec.modelSpec - #1071
Open
dundysm wants to merge 1 commit into
Open
[Feat] Support command and args on servingEngineSpec.modelSpec#1071dundysm wants to merge 1 commit into
dundysm wants to merge 1 commit into
Conversation
The main vLLM container currently hardcodes `vllm serve`. Optional command and args on each modelSpec let users wrap startup (for example mkdir before exec) the same way init containers already can. Fixes vllm-project#682 Signed-off-by: Dundy Pasupuleti <pasupuletidundy@gmail.com>
dundysm
requested review from
ApostaC,
YuhanLiu11 and
ruizhang0101
as code owners
September 1, 2026 20:56
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring custom commands and arguments for the main vLLM container in the multi-deployment Helm chart. It updates the deployment template to conditionally render command and args if specified in the model configuration, adds corresponding schema definitions in values.schema.json, provides commented-out examples in values.yaml, and includes a unit test to verify the new behavior. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main vLLM container currently hardcodes
vllm serve. This adds optionalcommandandargson eachservingEngineSpec.modelSpec[]entry so startup can be wrapped the same way init containers already can (the Prometheus/LMCache mkdir case from the issue).When
commandis unset, the defaultvllm serveinvocation is unchanged.vllmConfig.extraArgsstill applies only to that default path.Fixes #682
helm lintandhelm template.-swhen doinggit commit[Feat])Testing
helm lint helm/— pass (chart dependency warning only)helm templatewith chart defaults — main container command staysvllm servehelm templatewithmodelSpec.command/modelSpec.args— customsh -cwrapper, defaultserveis not in commandhelm/tests/deployment-vllm-multi_test.yaml