Conversation
Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Qwen3-ASR documentation by integrating instructions for AMD users. It provides clear guidance on how to set up vLLM and deploy the Qwen3-ASR model on systems equipped with ROCm-compatible hardware, thereby broadening the accessibility and usability of the model for a wider range of hardware configurations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for Qwen3-ASR to include instructions for AMD GPUs using ROCm. The changes are helpful and add valuable information for users with AMD hardware. I've pointed out a couple of minor issues in the markdown formatting: incorrect heading levels which disrupt the document structure, and an extra blank line. Correcting these will improve the clarity and correctness of the documentation.
| ## Launching Qwen3-ASR with vLLM | ||
| ### Online Serving | ||
| You can easily deploy Qwen3-ASR with vLLM by running the following command | ||
| ### CUDA |
There was a problem hiding this comment.
The heading level for CUDA appears to be incorrect. It's currently a level 3 heading (###), which makes it a sibling of Online Serving in the document structure. To correctly place it as a sub-section of Online Serving, it should be a level 4 heading (####). This will also fix the document outline, ensuring subsequent sections like Using OpenAI SDK are correctly nested.
| ### CUDA | |
| #### CUDA |
| ```bash | ||
| vllm serve Qwen/Qwen3-ASR-1.7B | ||
| ``` | ||
| ### ROCm |
There was a problem hiding this comment.
Similar to the CUDA heading, the heading level for ROCm appears to be incorrect. It's currently a level 3 heading (###), making it a sibling of Online Serving. It should be a level 4 heading (####) to be a sub-section under Online Serving.
| ### ROCm | |
| #### ROCm |
| vllm serve Qwen/Qwen3-ASR-1.7B | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
There is an extra blank line here. For better readability of the markdown source, it's best to use only one blank line to separate blocks of content.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| ## Launching Qwen3-ASR with vLLM | ||
| ### Online Serving | ||
| You can easily deploy Qwen3-ASR with vLLM by running the following command | ||
| ### CUDA |
| ```bash | ||
| vllm serve Qwen/Qwen3-ASR-1.7B | ||
| ``` | ||
| ### ROCm |
| vllm serve Qwen/Qwen3-ASR-1.7B | ||
| ``` | ||
|
|
||
|
|
2 participants
No description provided.