Skip to content

[AMD] add minimax mi355x's config#300

Open
benenzhu wants to merge 4 commits intovllm-project:mainfrom
benenzhu:minimax-mi355
Open

[AMD] add minimax mi355x's config#300
benenzhu wants to merge 4 commits intovllm-project:mainfrom
benenzhu:minimax-mi355

Conversation

@benenzhu
Copy link
Copy Markdown

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the documentation for the MiniMax-M2.5 model by incorporating comprehensive configuration details for AMD MI355X GPUs. It outlines specific Docker commands and environment variables necessary to leverage the vLLM ROCm image, enabling users to run the model with optimized performance across various tensor and expert parallelism settings.

Highlights

  • AMD MI355X Configuration: Added detailed configuration instructions for running the MiniMax-M2.5 model on AMD MI355X GPUs, specifically targeting FP8 precision.
  • Performance Optimization: Included the VLLM_ROCM_USE_AITER=1 environment variable in the Docker commands to enable the AITER backend for optimized performance on ROCm.
  • Parallelism Configurations: Provided distinct Docker run commands for different parallelism setups: TP=2 or TP=4 without expert parallelism, and TP=8 with EP=8 for higher throughput.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds documentation for running MiniMax-M2.5 on AMD MI355X GPUs. I've found a couple of critical issues in the provided docker run commands: they are syntactically incorrect due to missing line continuation characters and are also missing essential parameters for the model's functionality. I've provided suggestions to fix these. Additionally, I've pointed out a minor ambiguity in one of the section titles for better clarity.

@benenzhu
Copy link
Copy Markdown
Author

Thanks Gemini, will fix later.

@benenzhu benenzhu changed the title [AMD] add minimax mi355x's config [DRAFT] [AMD] add minimax mi355x's config Mar 23, 2026
@benenzhu benenzhu marked this pull request as draft March 23, 2026 11:35
@benenzhu benenzhu changed the title [DRAFT] [AMD] add minimax mi355x's config [AMD] add minimax mi355x's config Apr 5, 2026
@benenzhu benenzhu marked this pull request as ready for review April 5, 2026 07:18
benenzhu and others added 4 commits April 5, 2026 07:22
Signed-off-by: zhutaoyu <zhutaoyu97@gmail.com>
Signed-off-by: Taoyu Zhu <z609495@gmail.com>
Signed-off-by: zhutaoyu <zhutaoyu97@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Taoyu Zhu <z609495@gmail.com>
Signed-off-by: zhutaoyu <zhutaoyu97@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Taoyu Zhu <z609495@gmail.com>
Signed-off-by: zhutaoyu <zhutaoyu97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant