fix:update grep pattern to capture envoy-specific logs more broadly#1628
fix:update grep pattern to capture envoy-specific logs more broadly#1628yash9263 wants to merge 7 commits intovllm-project:mainfrom
Conversation
❌ Deploy Preview for vllm-semantic-router failed.
|
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Xunzhuo
left a comment
There was a problem hiding this comment.
thanks can you also check other component logs, and see if they need to be optimized?
|
@yash9263 can you sign DCO and fix the precommit error? |
578979b to
680d636
Compare
Signed-off-by: yashwant <yashwant8530@gmail.com>
Signed-off-by: yashwant <yashwant8530@gmail.com>
680d636 to
0b6f7d3
Compare
|
@Xunzhuo, could you provide a bit more context on the kind of optimisation you're looking for in the other components? |
|
@yash9263 there are other components when we run vllm-sr serve in local besides envoy, so we need to check it their patterns are good enough |
|
Hi @Xunzhuo, I reviewed the router and dashboard logs, and the current pattern seems to capture most logs from these two services. However, for the envoy logs even after these new changes it's not able to capture the logs completely, please let me know if this is expected. docker logs: ==> /var/log/supervisor/envoy.log <==
2026-03-26 19:07:09,927 - INFO - Configuration parsed successfully
2026-03-26 19:07:09,927 - INFO - Version: v0.3
2026-03-26 19:07:09,927 - INFO - Listeners: 1
2026-03-26 19:07:09,927 - INFO - Decisions: 1
2026-03-26 19:07:09,927 - INFO - Models: 1
2026-03-26 19:07:09,928 - INFO - Generating Envoy config...
2026-03-26 19:07:09,928 - INFO - Listeners:
2026-03-26 19:07:09,928 - INFO - - http-8899: 0.0.0.0:8899
2026-03-26 19:07:09,928 - INFO - Found 1 vLLM model(s):
2026-03-26 19:07:09,928 - INFO - - Model-A (cluster: Model_A)
2026-03-26 19:07:09,928 - INFO - - primary: localhost:8000 (weight: 100)
2026-03-26 19:07:09,947 - INFO - Generated Envoy config: /etc/envoy/envoy.yaml
2026-03-26 19:07:09,947 - INFO - Envoy configuration generated: /etc/envoy/envoy.yamlcaptured: 2026-03-26 19:07:09,947 - INFO - Generated Envoy config: /etc/envoy/envoy.yaml
2026-03-26 19:07:09,947 - INFO - Envoy configuration generated: /etc/envoy/envoy.yamlI think relying on the grep pattern may not be the most reliable approach. |
✅ Supply Chain Security Report — All Clear
Scanned at |
…ncomplete-envoy-logs-output
|
I think recent commit to separate the container from the all in one vllm-sr container has solved this issue, we don't need to grep anymore. Would you like to pick other issues if you are interested? |
|
yeah sure, let me know if you have something in mind, or I'm happy to pick something up myself. |
|
close this for done in separation PR, thanks for picking it up |

Closes #1083
Summary
This PR updates the grep pattern to capture the Envoy logs that are being missed. It relaxes the regex pattern to capture additional evoy-related logs, which are being missed.
yes/nonone/TDxxxValidation
cpu-local/amd-local/not runChecklist
[Bugfix],[CI/Build],[CLI],[Dashboard],[Doc],[Feat],[Router], or[Misc]git commit -sSee CONTRIBUTING.md for the full contributor workflow and commit guidance.