Skip to content

fix:update grep pattern to capture envoy-specific logs more broadly#1628

Closed
yash9263 wants to merge 7 commits intovllm-project:mainfrom
yash9263:bug-incomplete-envoy-logs-output
Closed

fix:update grep pattern to capture envoy-specific logs more broadly#1628
yash9263 wants to merge 7 commits intovllm-project:mainfrom
yash9263:bug-incomplete-envoy-logs-output

Conversation

@yash9263
Copy link
Copy Markdown

Closes #1083

Summary

This PR updates the grep pattern to capture the Envoy logs that are being missed. It relaxes the regex pattern to capture additional evoy-related logs, which are being missed.

  • Scope:
  • Primary skill:
  • Impacted surfaces:
  • Conditional surfaces intentionally skipped:
  • Behavior-visible change: yes / no
  • Debt entry: none / TDxxx

Validation

  • Environment: cpu-local / amd-local / not run
  • Fast gate:
  • Feature gate:
  • Local smoke / E2E:
  • CI expectations / blockers:

Checklist

  • PR title uses the repo prefix format: [Bugfix], [CI/Build], [CLI], [Dashboard], [Doc], [Feat], [Router], or [Misc]
  • If the PR spans multiple categories, the title includes all relevant prefixes
  • Commits in this PR are signed off with git commit -s
  • Source-of-truth docs or indexed debt entries were updated when applicable
  • The validation results above reflect the actual commands or blockers for this change

See CONTRIBUTING.md for the full contributor workflow and commit guidance.

@yash9263 yash9263 requested review from Xunzhuo and rootfs as code owners March 22, 2026 20:04
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 22, 2026

Deploy Preview for vllm-semantic-router failed.

Name Link
🔨 Latest commit 4ded3f5
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/69c04b4b915dee0008910c55

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 22, 2026

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 4301d60
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/69ce486a9a6331000852c55a
😎 Deploy Preview https://deploy-preview-1628--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 22, 2026

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 dashboard

Owners: @Xunzhuo, @JaredforReal, @haowu1234, @szedan-rh, @yehuditkerido, @henschwartz
Files changed:

  • dashboard/backend/handlers/logs.go

📁 src/vllm-sr

Owners: @Xunzhuo, @szedan-rh, @yehuditkerido, @henschwartz, @mkoushni, @liavweiss, @noalimoy, @haowu1234
Files changed:

  • src/vllm-sr/cli/core.py

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

Xunzhuo
Xunzhuo previously approved these changes Mar 23, 2026
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks can you also check other component logs, and see if they need to be optimized?

rootfs
rootfs previously approved these changes Mar 23, 2026
@rootfs
Copy link
Copy Markdown
Collaborator

rootfs commented Mar 23, 2026

@yash9263 can you sign DCO and fix the precommit error?

@yash9263 yash9263 dismissed stale reviews from rootfs and Xunzhuo via d2db46e March 23, 2026 14:53
@yash9263 yash9263 force-pushed the bug-incomplete-envoy-logs-output branch 2 times, most recently from 578979b to 680d636 Compare March 23, 2026 14:57
Signed-off-by: yashwant <yashwant8530@gmail.com>
Signed-off-by: yashwant <yashwant8530@gmail.com>
@yash9263 yash9263 force-pushed the bug-incomplete-envoy-logs-output branch from 680d636 to 0b6f7d3 Compare March 23, 2026 15:03
@yash9263
Copy link
Copy Markdown
Author

@Xunzhuo, could you provide a bit more context on the kind of optimisation you're looking for in the other components?

@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Mar 23, 2026

@yash9263 there are other components when we run vllm-sr serve in local besides envoy, so we need to check it their patterns are good enough

rootfs
rootfs previously approved these changes Mar 24, 2026
@yash9263
Copy link
Copy Markdown
Author

Hi @Xunzhuo, I reviewed the router and dashboard logs, and the current pattern seems to capture most logs from these two services. However, for the envoy logs even after these new changes it's not able to capture the logs completely, please let me know if this is expected.

docker logs:

==> /var/log/supervisor/envoy.log <==
2026-03-26 19:07:09,927 - INFO - Configuration parsed successfully
2026-03-26 19:07:09,927 - INFO -   Version: v0.3
2026-03-26 19:07:09,927 - INFO -   Listeners: 1
2026-03-26 19:07:09,927 - INFO -   Decisions: 1
2026-03-26 19:07:09,927 - INFO -   Models: 1
2026-03-26 19:07:09,928 - INFO - Generating Envoy config...
2026-03-26 19:07:09,928 - INFO -   Listeners:
2026-03-26 19:07:09,928 - INFO -     - http-8899: 0.0.0.0:8899
2026-03-26 19:07:09,928 - INFO -   Found 1 vLLM model(s):
2026-03-26 19:07:09,928 - INFO -     - Model-A (cluster: Model_A)
2026-03-26 19:07:09,928 - INFO -         - primary: localhost:8000 (weight: 100)
2026-03-26 19:07:09,947 - INFO - Generated Envoy config: /etc/envoy/envoy.yaml
2026-03-26 19:07:09,947 - INFO - Envoy configuration generated: /etc/envoy/envoy.yaml

captured:

2026-03-26 19:07:09,947 - INFO - Generated Envoy config: /etc/envoy/envoy.yaml
2026-03-26 19:07:09,947 - INFO - Envoy configuration generated: /etc/envoy/envoy.yaml

I think relying on the grep pattern may not be the most reliable approach.
Reading logs using the options 2 or 3 mentioned in the original issue would be a more robust approach.
Let me know your thoughts!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

✅ Supply Chain Security Report — All Clear

Scanner Status Findings
AST Codebase Scan (Py, Go, JS/TS, Rust) 28 finding(s) — MEDIUM: 21 · LOW: 7
AST PR Diff Scan No issues detected
Regex Fallback Scan No issues detected

Scanned at 2026-04-02T11:19:02.179Z · View full workflow logs

@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Mar 27, 2026

I think recent commit to separate the container from the all in one vllm-sr container has solved this issue, we don't need to grep anymore.

Would you like to pick other issues if you are interested?

@yash9263
Copy link
Copy Markdown
Author

yeah sure, let me know if you have something in mind, or I'm happy to pick something up myself.

@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Apr 2, 2026

close this for done in separation PR, thanks for picking it up

@Xunzhuo Xunzhuo closed this Apr 2, 2026
@yash9263 yash9263 deleted the bug-incomplete-envoy-logs-output branch April 2, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: incomplete Envoy logs output due to overly restrictive grep patterns

10 participants