[Feat](operator): split operator config contract across schema, validation, and canonical translation#1694
Open
FAUST-BENCHOU wants to merge 3 commits intovllm-project:mainfrom
Open
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Contributor
✅ Supply Chain Security Report — All Clear
Scanned at |
9fb8666 to
b533c85
Compare
…ion, and canonical translation Signed-off-by: zhoujinyu <2319109590@qq.com>
b533c85 to
ce87793
Compare
Contributor
Author
this ci error was not introduced by me,anyway i will try to figure it out |
Signed-off-by: zhoujinyu <2319109590@qq.com>
FAUST-BENCHOU
commented
Apr 1, 2026
Comment on lines
-1039
to
+1046
| MountPath: "/app/config", | ||
| MountPath: "/app/config/config.yaml", | ||
| SubPath: "config.yaml", | ||
| ReadOnly: true, | ||
| }, | ||
| { | ||
| Name: "config-volume", | ||
| MountPath: "/app/config/tools_db.json", | ||
| SubPath: "tools_db.json", |
Contributor
Author
There was a problem hiding this comment.
this part has nothing to do with issue #1595
but i consider it as a bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #1595
Summary
The Operator API has been separated from a single file:
semanticrouter_typesis domain-specific, andsemanticrouter_webhookis only responsible for registration; validation is centralized insemanticrouter_validate_deployment.goandsemanticrouter_validate_configspec*.go, withvalidateConfigSpec()chained to the end ofvalidateSemanticRouter.canonical_config_builderdelegates the translation of each domain tocanonical_config_operator_*.go. Samples and tests are now aligned with the manifest/fixture seams.Checklist
[Bugfix],[CI/Build],[CLI],[Dashboard],[Doc],[Feat],[Router], or[Misc]git commit -sSee CONTRIBUTING.md for the full contributor workflow and commit guidance.