[Router] Fix: wire Valkey config into createSemanticCache#1737
Merged
rootfs merged 2 commits intovllm-project:mainfrom Apr 10, 2026
Merged
[Router] Fix: wire Valkey config into createSemanticCache#1737rootfs merged 2 commits intovllm-project:mainfrom
rootfs merged 2 commits intovllm-project:mainfrom
Conversation
The Valkey field was missing from the CacheConfig struct initialization in createSemanticCache, causing Valkey semantic cache backend to always fail with "valkey configuration is required" even when properly configured. Signed-off-by: Daria Korenieva <daric2612@gmail.com>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
assigned
abdallahsamabd,
asaadbalum,
liavweiss,
noalimoy,
rootfs,
szedan-rh,
Xunzhuo and
yehuditkerido
Contributor
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Contributor
✅ Supply Chain Security Report — All Clear
Scanned at |
Contributor
Author
|
@rootfs this PR is a fix to properly wire Valkey config. Please take a look when you have a chance |
rootfs
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Valkeyfield was missing from theCacheConfigstruct initialization increateSemanticCache, causing the Valkey semantic cache backend to always fail with"valkey configuration is required"even when properly configured in the router config.Valkey: semanticCacheCfg.Valkeyalongside the existingRedisandMilvusfields.