[CI] e2e: add Response API basic operations tests #826
Conversation
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@tao12345666333 this is great! Do you like to add it to the CI now, so we can see the test results? |
Add E2E tests for Response API basic operations:
- POST /v1/responses - Create a new response
- GET /v1/responses/{id} - Retrieve a response
- DELETE /v1/responses/{id} - Delete a response
- GET /v1/responses/{id}/input_items - List input items
Signed-off-by: Jintao Zhang <[email protected]>
|
Thanks @rootfs! Yes, I'd like to add it to CI. For the Response API tests, we have two options:
I think option 1 is simpler for now. I'll add the Response API tests to the Docker Compose CI in a follow-up commit. |
- Enable Response API in config/config.yaml
- Add Response API test steps to integration-test-docker.yml:
- POST /v1/responses (create)
- GET /v1/responses/{id} (retrieve)
- GET /v1/responses/{id}/input_items (list input items)
- DELETE /v1/responses/{id} (delete and verify 404)
Signed-off-by: Jintao Zhang <[email protected]>
tao12345666333
force-pushed
the
e2e-basic-crud
branch
from
a19c629 to
b49a46d
Compare
|
@tao12345666333 sounds good! let's have this PR first and you can follow up with k8s CI PR next. |
|
OK, thank you! |
3 participants
part of #805
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews