Skip to content

Disable the peformance comparision agaist baseline, keep just the per… #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xunzhuo merged 1 commit into from
Dec 15, 2025
+4 −31
Merged

Disable the peformance comparision agaist baseline, keep just the per… #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/performance-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: Nightly Performance Baseline

on:
schedule:
# Run at 3:00 AM UTC daily
- cron: "0 3 * * *"
# Disabled - baseline comparison not currently used in PR tests
# schedule:
# # Run at 3:00 AM UTC daily
# - cron: "0 3 * * *"
workflow_dispatch: # Allow manual triggering

jobs:
Expand Down
28 changes: 0 additions & 28 deletions .github/workflows/performance-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ jobs:
steps:
- name: Check out the repo
uses: actions/checkout@v4
with:
fetch-depth: 0 # Need full history for baseline comparison

- name: Set up Go
uses: actions/setup-go@v5
Expand Down Expand Up @@ -83,14 +81,6 @@ jobs:
HF_HUB_DISABLE_TELEMETRY: 1
run: make download-models

- name: Download performance baselines
continue-on-error: true
run: |
mkdir -p perf/testdata/baselines
git show main:perf/testdata/baselines/classification.json > perf/testdata/baselines/classification.json 2>/dev/null || echo '{"version":"v1.0.0","benchmarks":{}}' > perf/testdata/baselines/classification.json
git show main:perf/testdata/baselines/decision.json > perf/testdata/baselines/decision.json 2>/dev/null || echo '{"version":"v1.0.0","benchmarks":{}}' > perf/testdata/baselines/decision.json
git show main:perf/testdata/baselines/cache.json > perf/testdata/baselines/cache.json 2>/dev/null || echo '{"version":"v1.0.0","benchmarks":{}}' > perf/testdata/baselines/cache.json

- name: Run component benchmarks
run: |
mkdir -p reports
Expand Down Expand Up @@ -177,21 +167,3 @@ jobs:
path: |
reports/
retention-days: 30

- name: Check for regressions (placeholder)
id: regression_check
continue-on-error: true
run: |
# In a real implementation, this would:
# 1. Parse benchmark output
# 2. Compare against baselines
# 3. Calculate % changes
# 4. Exit 1 if regressions exceed thresholds
echo "No regressions detected (placeholder check)"

- name: Fail on regression
if: steps.regression_check.outcome == 'failure'
run: |
echo "❌ Performance regressions detected!"
echo "See benchmark results in artifacts for details"
exit 1
Loading