Skip to content

Update torch requirement from <=2.11.0,>=2.9.0 to >=2.9.0,<=2.12.0#534

Merged
fynnsu merged 5 commits into
mainfrom
dependabot/pip/torch-gte-2.9.0-and-lte-2.12.0
May 28, 2026
Merged

Update torch requirement from <=2.11.0,>=2.9.0 to >=2.9.0,<=2.12.0#534
fynnsu merged 5 commits into
mainfrom
dependabot/pip/torch-gte-2.9.0-and-lte-2.12.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github May 19, 2026 •
edited by fynnsu
Loading

Copy link
Copy Markdown
Contributor

Edit by @fynnsu:
Fixed a small typing issue
Removed setuptools from package dependencies (not used and was causing torch version to resolve to 2.10).
Also had to mark some stuff w/ @torch.compiler.disable.

E2E job: https://github.com/neuralmagic/llm-compressor-testing/actions/runs/26538320010

Updates the requirements on torch to permit the latest version.

Release notes

Sourced from torch's releases.

PyTorch 2.12.0 Release Notes

Highlights

For more details about these highlighted features, you can look at the release blogpost. Below are the full release notes for this release.

Backwards Incompatible Changes

Build Frontend

  • Strengthened SVE compile checks in FindARM.cmake, which may reject previously accepted but incorrect SVE configurations (#176646)

    Source builds that enable SVE now validate the compiler configuration more strictly. If a build previously passed with an incomplete or mismatched SVE setup, it may now fail during CMake configuration instead of later in compilation. Update the compiler/toolchain flags so they accurately describe the target SVE support, or disable SVE for that build.

  • Updated the minimum CUDA version required to build PyTorch from source to CUDA 12.6 (#178925)

    Building PyTorch from source with CUDA versions older than 12.6 is no longer supported. Users building custom binaries should install CUDA 12.6 or newer and make sure CUDA_HOME points to that installation.

    Version 2.11:

    CUDA_HOME=/usr/local/cuda-12.4 python setup.py develop

    Version 2.12:

    CUDA_HOME=/usr/local/cuda-12.6 python setup.py develop

  • Enforced a C++20 minimum in CMake build files (#178662)

... (truncated)

Changelog

Sourced from torch's changelog.

Releasing PyTorch

Release Compatibility Matrix

Following is the Release Compatibility Matrix for PyTorch releases:

... (truncated)

Commits
  • 0d62256 [release] Dockerfile: skip torchaudio install when CUDA_PATH=cu132 (#183346)
  • 7661cd9 [MPS] Fix SDPA wrong output for permuted q/k/v with B > 1 (#181886)
  • 9da6087 Fix stale PYTORCH_RELEASES_CODE_CC dict (fixes #182250) (#182369)
  • e4c37cc Avoid raw stream name collisions in Inductor (#182178)
  • 822d047 [MPS] Fix bool mask handling in 1-pass SDPA decode kernel (#182285) (#182311)
  • 5c5e523 Add enable_gqa parameter to SDPA MPS meta registration (#181550)
  • eece52e [AOTI] Add BC-safe c_shim v2 for _scaled_dot_product_attention_math_for_mps e...
  • b39330b [Inductor] Call latest c_shim version for versioned fallback ops (#181548)
  • 06f10d0 Revert "[FSDP2] add fqn to communication ops" (#182100) (#182157)
  • 449e339 Revert "[Inductor] Improve materialization heuristic for a chain of computaio...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels May 19, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@mergify

mergify Bot commented May 19, 2026

Copy link
Copy Markdown

The quality checks have failed. Please run make style and make quality under
the root directory to address the lint failures. You will need to install the
dev optional install to get the required linting packages:
https://github.com/vllm-project/speculators/blob/main/CONTRIBUTING.md

@fynnsu fynnsu force-pushed the dependabot/pip/torch-gte-2.9.0-and-lte-2.12.0 branch from d6ebf59 to 49463e3 Compare May 20, 2026 17:47
@mergify mergify Bot removed the quality-failed label May 20, 2026
fynnsu
fynnsu requested changes May 21, 2026
View reviewed changes

@fynnsu fynnsu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until e2e failures are resolved

dependabot Bot and others added 3 commits May 26, 2026 21:15
@dependabot @fynnsu
Update torch requirement from <=2.11.0,>=2.9.0 to >=2.9.0,<=2.12.0
3104ed4 
Updates the requirements on [torch](https://github.com/pytorch/pytorch) to permit the latest version.
- [Release notes](https://github.com/pytorch/pytorch/releases)
- [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md)
- [Commits](pytorch/pytorch@v2.9.0...v2.12.0)

---
updated-dependencies:
- dependency-name: torch
  dependency-version: 2.12.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@fynnsu
Remove tensor cast
32a4282 
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
@fynnsu
Remove setuptools from package dependencies
1cc76c8 
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
@fynnsu fynnsu force-pushed the dependabot/pip/torch-gte-2.9.0-and-lte-2.12.0 branch from 49463e3 to 1cc76c8 Compare May 26, 2026 21:24
fynnsu added 2 commits May 26, 2026 22:09
@fynnsu
Fix dflash recompile invalid cache hits
14f16ad 
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
@fynnsu
Disable compilation on extend fn
53ab13b 
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
@mergify

mergify Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Require two reviews

Wonderful, this rule succeeded.

PRs labelled "two-reviews" must have at least two approving reviews before merging.

  • #approved-reviews-by >= 2

fynnsu
fynnsu approved these changes May 27, 2026
View reviewed changes

@fynnsu fynnsu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed e2e (except expected peagle failure)

@fynnsu fynnsu requested a review from shanjiaz May 27, 2026 22:07
shanjiaz
shanjiaz approved these changes May 28, 2026
View reviewed changes

@shanjiaz shanjiaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for running the e2e. We should probably add tests for training time regression to make sure performance doesn't drop for things like these.

@fynnsu fynnsu enabled auto-merge (squash) May 28, 2026 13:55
@fynnsu

fynnsu commented May 28, 2026

Copy link
Copy Markdown
Collaborator

@mergify refresh

@mergify

mergify Bot commented May 28, 2026

Copy link
Copy Markdown

refresh

✅ Pull request refreshed

@fynnsu fynnsu merged commit c1bb3cd into main May 28, 2026
14 of 15 checks passed
@fynnsu fynnsu deleted the dependabot/pip/torch-gte-2.9.0-and-lte-2.12.0 branch May 28, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fynnsu fynnsu fynnsu approved these changes
@shanjiaz shanjiaz shanjiaz approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code two-reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fynnsu @shanjiaz