Open
Conversation
Signed-off-by: Pysith Vanuptikul <piv@google.com> Signed-off-by: <piv@google.com>
pv97
requested review from
jrplatin,
kyuyeunk,
mrjunwan-lang,
sixiang-google,
vanbasten23 and
wenxindongwork
as code owners
ryanaoleary
reviewed
Mar 9, 2026
tpu_inference/worker/tpu_worker.py
Outdated
| if self.parallel_config.pipeline_parallel_size > 1: | ||
| # Log environment variables for debugging | ||
| tpu_env_vars = [ | ||
| "TPU_PROCESS_ADDRESSES", |
There was a problem hiding this comment.
I believe TPU_PROCESS_ADDRESSES is only introduced for tpu7x, otherwise it'll be TPU_WORKER_HOSTNAMES which should have the same values as the former, except without the TPU port appended to the address. Also it might be useful to dump the TPU_WORKER_ID as well
There was a problem hiding this comment.
Same with TPU_PROCESS_PORT - I don't think this is set automatically before tpu7x
Signed-off-by: Pysith Vanuptikul <piv@google.com> Signed-off-by: <piv@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Start with a short description of what the PR does and how this is a change from
the past.
The rest of the description includes relevant details and context, examples:
If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure: