[Parallelism Support Matrix Tests] Replace flaky EP relative comparison with hardcoded absolute baseline#1984
Open
syhuang22 wants to merge 1 commit intovllm-project:mainfrom
Open
Conversation
Signed-off-by: Shy Huang <shyhuang@google.com>
e500d4b to
e4f04cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous approach was unreliable because
any upstream vllm change could shift the baseline, causing spurious
failures unrelated to EP performance.
Now the tests compare EP inference time against hardcoded baselines measured on
TPU v7x-8 (512 prompts, Fused: 3.40s, GMM: 2.07s). Tests fail only if
regression exceeds 15%, making them stable and independent of non-EP code paths.
Tests
Both tests verified on TPU v7x-8:
test_ep_fused_performance: 3.35s (baseline 3.40s, -1.5%) — PASSEDtest_ep_gmm_performance: 2.21s (baseline 2.07s, +6.6%) — PASSED