Skip to content

env fix#2077

Open
clee1994 wants to merge 6 commits intovllm-project:mainfrom
clee1994:env_fix
Open

env fix#2077
clee1994 wants to merge 6 commits intovllm-project:mainfrom
clee1994:env_fix

Conversation

@clee1994
Copy link
Copy Markdown
Collaborator

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@clee1994 clee1994 requested a review from vipannalla as a code owner March 28, 2026 20:43
args_to_append = []

# Check for the first flag
if "xla_tpu_use_tc_device_shape_on_sc" not in current_args:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you make this into a separate function? like, maybe_append_arg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants