Skip to content

Autobump tokamax pin - #3535

Open
vanbasten23 wants to merge 5 commits into
mainfrom
xiowei/add_autobump_tokamax_pin
Open

Autobump tokamax pin#3535
vanbasten23 wants to merge 5 commits into
mainfrom
xiowei/add_autobump_tokamax_pin

Conversation

@vanbasten23

@vanbasten23 vanbasten23 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Description

Execution workflow:

  1. Schedule/manual → the pipeline's single step runs bootstrap_tokamax.sh

It sets TOKAMAX_VERSION, TOKAMAX_PREVIOUS_VERSION, VLLM_COMMIT_HASH as meta-data, uploads four yml documents, and exits. No build, no tests yet.

  1. build_docker ×2 (pipeline_build.yml, one per TPU generation — build_docker_tpu6e and build_docker_tpu7x, defined in .buildkite/pipeline_build.yml)

This is setup_docker_env.sh's build path:

  • reads TOKAMAX_VERSION from meta-data
  • seds requirements.txt
  • appends -tkmx to CACHE_TAG
  • builds
  • runs verify_image_tokamax
  • pushes to the CI registry.
  1. Every TPU test step (pipeline_jax.yml, v6e + v7x)

run_in_docker.sh → setup_environment again, this time the pull path (USE_PREBUILT_IMAGE=1, run_in_docker.sh): recomputes the same CACHE_TAG from the same meta-data, pulls, and verify_image_tokamax confirms the right image arrived.

  1. *_tpu_test_notification per group: check test result.

  2. - wait: ~ in integration_tokamax_promote.yml — passes only if everything above passed.

  3. promote_tokamax: pushes the bump to main.

Comparison tokamax pin with vLLM pin update:

  • tokamax_promote.yml vs integration_promote.yml
  • update_tokamax_pin.sh vs update_lkg_version.sh
  • bootstrap_tokamax.sh vs the tpu-vllm-integration branch of bootstrap.sh
  • requirements.txt (tokamax==) vs .buildkite/vllm_lkg.version

Tests

CI

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com>
…, similar to the existing update_lkg_version.sh

Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com>
…l, mirroring the existing integration_promote.yml.

Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com>
…x.sh, mirroring the tpu-vllm-integration branch of bootstrap.sh:271-287

Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com>
Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com>
@vanbasten23
vanbasten23 force-pushed the xiowei/add_autobump_tokamax_pin branch from 863d90d to 7278500 Compare September 4, 2026 23:24
@vanbasten23 vanbasten23 changed the title Xiowei/add autobump tokamax pin Autobump tokamax pin Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@vanbasten23 vanbasten23 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 5, 2026
@vanbasten23
vanbasten23 marked this pull request as ready for review September 5, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant