[CI]accurcy Test#10530
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces infrastructure for code coverage tracking within the project. By adding the necessary dependency and configuring the coverage tool, the team can now measure and analyze test execution paths, which is essential for maintaining high code quality and identifying untested areas of the codebase. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
Suggested PR Title:
[Test][Feature] Add coverage configuration and dependencySuggested PR Summary:
### What this PR does / why we need it?
This PR adds the `coverage` package to `requirements-dev.txt` and introduces a `.coveragerc` configuration file to enable code coverage tracking for the `vllm_ascend` module.
Feedback:
- The `data_file` path in `tests/coveragerc` is hardcoded to a specific user's directory (`/mnt/share/s00837289/covdata/coverage`), which will cause failures in other environments or CI. It should be changed to a relative path.
- The `include` path `/vllm_ascend/*` is absolute and should be changed to a relative pattern like `vllm_ascend/*` to ensure proper matching.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No tests were added as this is a configuration change.| # 指定覆盖数据中文件路径采用绝对路径,便于后续分析时路径匹配 | ||
| relative_files = False | ||
| # 指定产生的覆盖数据文件基础名称,可采用绝对路径 | ||
| data_file = /mnt/share/s00837289/covdata/coverage |
There was a problem hiding this comment.
The data_file path is hardcoded to a specific user's directory (/mnt/share/s00837289/covdata/coverage). This will cause coverage collection to fail on other environments or CI systems where this path does not exist or is not writable. Please use a relative path or a generic directory to ensure portability.
data_file = .coverage_data/coverage
| include = | ||
| */vllm_ascend/* | ||
| # 目录usr下任何格式python代码 | ||
| /vllm_ascend/* |
There was a problem hiding this comment.
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
|
/rerun |
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?