Skip to content

[CI]accurcy Test#10530

Open
shiqiangA wants to merge 9 commits into
vllm-project:mainfrom
shiqiangA:new_full_coverage
Open

[CI]accurcy Test#10530
shiqiangA wants to merge 9 commits into
vllm-project:mainfrom
shiqiangA:new_full_coverage

Conversation

@shiqiangA

@shiqiangA shiqiangA commented Jun 16, 2026

Copy link
Copy Markdown

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: shiqiangA <shiqiang15@huawei.com>
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces infrastructure for code coverage tracking within the project. By adding the necessary dependency and configuring the coverage tool, the team can now measure and analyze test execution paths, which is essential for maintaining high code quality and identifying untested areas of the codebase.

Highlights

  • Dependency Update: Added the 'coverage' package to requirements-dev.txt to support code coverage analysis.
  • Configuration Setup: Introduced a new '.coveragerc' configuration file in the tests directory to define coverage collection parameters, including concurrency settings and file inclusion/exclusion rules.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/_selected_tests.yaml
    • .github/workflows/pr_test.yaml
    • .github/workflows/scripts/run_selected_tests.sh
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Suggested PR Title:

[Test][Feature] Add coverage configuration and dependency

Suggested PR Summary:

### What this PR does / why we need it?
This PR adds the `coverage` package to `requirements-dev.txt` and introduces a `.coveragerc` configuration file to enable code coverage tracking for the `vllm_ascend` module.

Feedback:
- The `data_file` path in `tests/coveragerc` is hardcoded to a specific user's directory (`/mnt/share/s00837289/covdata/coverage`), which will cause failures in other environments or CI. It should be changed to a relative path.
- The `include` path `/vllm_ascend/*` is absolute and should be changed to a relative pattern like `vllm_ascend/*` to ensure proper matching.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No tests were added as this is a configuration change.

Comment thread tests/coveragerc
# 指定覆盖数据中文件路径采用绝对路径,便于后续分析时路径匹配
relative_files = False
# 指定产生的覆盖数据文件基础名称,可采用绝对路径
data_file = /mnt/share/s00837289/covdata/coverage

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The data_file path is hardcoded to a specific user's directory (/mnt/share/s00837289/covdata/coverage). This will cause coverage collection to fail on other environments or CI systems where this path does not exist or is not writable. Please use a relative path or a generic directory to ensure portability.

data_file = .coverage_data/coverage

Comment thread tests/coveragerc
include =
*/vllm_ascend/*
# 目录usr下任何格式python代码
/vllm_ascend/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The include path /vllm_ascend/* specifies an absolute path starting from the root directory. This will likely fail to match the source files unless they are located at the filesystem root. Consider using a relative path pattern like vllm_ascend/* instead.

    vllm_ascend/*

Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
@shiqiangA

Copy link
Copy Markdown
Author

/rerun

Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Signed-off-by: shiqiangA <shiqiang15@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant