-
Notifications
You must be signed in to change notification settings - Fork 661
[Misc] Upgrade vllm hash to 12_14 #5000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on upgrading the vLLM hash and ensuring compatibility with the new version. The changes are well-structured, involving API adaptations, refactoring for backward compatibility (e.g., expert_map handling), and introducing version-conditional logic, particularly for vLLM v0.12.0. Overall, the changes appear correct and necessary for the upgrade. I've identified one minor issue in a test file where a model is duplicated, which should be addressed to avoid redundant test runs.
751e9a7 to
ccb5fcc
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ccb5fcc to
2f0110b
Compare
|
follow up:1. |
|
the full CI passed here https://github.com/vllm-project/vllm-ascend/actions/runs/20224367586/job/58052479148?pr=5000 |
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
5852b77 to
0969842
Compare
What this PR does / why we need it?
Does this PR introduce any user-facing change?
pooling models now supports chunked prefill and prefix caching,
multimodal_cpu_fieldsdefinition to field config vllm#30181define the CPU fields in the field config where they really belong.
define the CPU fields in the field config where they really belong.
some moudle rename
fusedmoe moudle refactor
fusedmoe moudle refactor
How was this patch tested?