Skip to content

Conversation

@zhaomingyu13
Copy link
Contributor

@zhaomingyu13 zhaomingyu13 commented Dec 15, 2025

What this PR does / why we need it?

Add user guide of speculative decoding that includes n-grams, EAGLE, and MTP.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new user guide for speculative decoding in vLLM Ascend. The guide covers n-grams, EAGLE, and MTP methods with code examples. The content is very helpful, but I've identified a few areas where the text can be improved for clarity and readability. My comments focus on fixing grammatical errors, run-on sentences, and formatting issues to enhance the overall quality of the documentation.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 15, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation merge-conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant