Skip to content

Conversation

@InSec
Copy link
Contributor

@InSec InSec commented Dec 15, 2025

What this PR does / why we need it?

Modify quantization tutorials to correct a few mistakes: Qwen3-32B-W4A4.md and Qwen3-8B-W4A8.md
Qwen3-8B-W4A8: need to set one idle npu card.
Qwen3-32B-W4A4: need to set two idle npu cards for the flatquant training and modify the calib_file path which does not match the ModeSlim version.

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides documentation updates for two quantization tutorials, Qwen3-32B-W4A4.md and Qwen3-8B-W4A8.md. The changes correct mistakes in the command-line examples. Specifically, for the Qwen3-32B-W4A4 tutorial, it adds the ASCEND_RT_VISIBLE_DEVICES environment variable to specify two NPU cards and corrects the path for the --calib_file argument. For the Qwen3-8B-W4A8 tutorial, it adds the ASCEND_RT_VISIBLE_DEVICES environment variable to specify a single NPU card. These changes are accurate and necessary for the tutorials to work as intended, improving the quality and correctness of the documentation.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 15, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wangxiyuan wangxiyuan merged commit a5cb8e4 into vllm-project:main Dec 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants