-
Notifications
You must be signed in to change notification settings - Fork 661
[Misc] Upgrade vllm commit hash to 1215 #5029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the vLLM commit hash and adapts the codebase to the changes in the new version. The changes primarily involve refactoring to align with upstream vLLM, such as replacing the custom InputBatch implementation with inheritance from the upstream class, and updating API calls with version checks for backward compatibility. One critical issue was found in an invalid type hint which would cause a syntax error.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
What this PR does / why we need it?
Upgrade vllm commit hash to
4429d934de3c5cc327b0d7aec8e473aeba38db90Does this PR introduce any user-facing change?
How was this patch tested?