-
Notifications
You must be signed in to change notification settings - Fork 661
[Bugfix] Fix the attn_metadata is None #5038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a TypeError that occurs when attn_metadata is None during a dummy run in MTP with ACL graph mode. The change correctly ensures that attn_metadata is constructed when aclgraph_runtime_mode is CUDAGraphMode.FULL, regardless of the skip_attn flag. This makes the logic more robust and resolves the potential for a crash. The fix is correct and well-targeted.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
yiz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the name of skip_attn, as its current name no longer accurately reflects its semantics. It would be more appropriate to rename it to in_graph_capturing or a similarly descriptive term.
e6af835 to
66fc48e
Compare
DONE. The old name is indeed not very easy to understand. |
Signed-off-by: chenmenglong <[email protected]>
66fc48e to
5ea1f4f
Compare
|
I’m afraid there is a misunderstanding here: |
What this PR does / why we need it?
Fix the bug " TypeError: 'NoneType' object is not iterable' " in vllm_ascend/compilation/acl_graph.py
The reason of that is the attn_metadata is none in the dummy_run of MTP.
Does this PR introduce any user-facing change?
How was this patch tested?