Skip to content

Conversation

@dragondream-chen
Copy link
Contributor

@dragondream-chen dragondream-chen commented Dec 15, 2025

What this PR does / why we need it?

Fix the bug " TypeError: 'NoneType' object is not iterable' " in vllm_ascend/compilation/acl_graph.py
The reason of that is the attn_metadata is none in the dummy_run of MTP.

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a TypeError that occurs when attn_metadata is None during a dummy run in MTP with ACL graph mode. The change correctly ensures that attn_metadata is constructed when aclgraph_runtime_mode is CUDAGraphMode.FULL, regardless of the skip_attn flag. This makes the logic more robust and resolves the potential for a crash. The fix is correct and well-targeted.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Collaborator

@yiz-liu yiz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the name of skip_attn, as its current name no longer accurately reflects its semantics. It would be more appropriate to rename it to in_graph_capturing or a similarly descriptive term.

@dragondream-chen
Copy link
Contributor Author

Please update the name of skip_attn, as its current name no longer accurately reflects its semantics. It would be more appropriate to rename it to in_graph_capturing or a similarly descriptive term.

DONE. The old name is indeed not very easy to understand.

@wangxiyuan wangxiyuan added ready read for review ready-for-test start test by label for PR labels Dec 15, 2025
@wangxiyuan wangxiyuan merged commit 5e0ada5 into vllm-project:main Dec 16, 2025
25 checks passed
@yiz-liu
Copy link
Collaborator

yiz-liu commented Dec 16, 2025

I’m afraid there is a misunderstanding here: skip_attn does not correspond to in_graph_capturing, in fact, it represents the opposite behavior. Please take a closer look at the underlying logic and revise it accordingly as soon as possible.
@dragondream-chen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants