Skip to content

Conversation

@MrZ20
Copy link
Contributor

@MrZ20 MrZ20 commented Dec 15, 2025

What this PR does / why we need it?

This Pull Request removes the @pytest.mark.skip decorators from test_mtp1_correctness_piecewise_graph and test_mtp2_correctness_piecewise_graph.

These tests were temporarily skipped because of an issue with the MTP ACL Graph (as per the original TODO comment). Since the relevant bug/issue has been resolved, these tests are now re-enabled to ensure full correctness coverage for MTP functionality.

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: MrZ20 <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables two MTP correctness tests, test_mtp1_correctness_piecewise_graph and test_mtp2_correctness_piecewise_graph, by removing their @pytest.mark.skip decorators. This is a welcome change that restores test coverage, following a fix for an issue with MTP ACL Graph. The changes are correct. While reviewing, I noticed that test_mtp1_correctness_piecewise_graph_with_pad and test_mtp2_correctness_piecewise_graph_with_pad remain skipped with a similar reason. It would be beneficial to verify if the current fix also resolves the issue for these _with_pad variants, and if so, re-enable them as well to ensure comprehensive test coverage for MTP functionality.

@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Dec 15, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Collaborator

@MengqingCao MengqingCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed due to unrelated cases, let's merge this quickly to unblock CI on mtp + aclgraph
https://github.com/vllm-project/vllm-ascend/actions/runs/20230899827/job/58073980686?pr=5039

@MengqingCao MengqingCao merged commit 237fad6 into vllm-project:main Dec 16, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants