Skip to content

Conversation

@frankie-ys
Copy link

@frankie-ys frankie-ys commented Dec 15, 2025

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds arctic-inference==0.1.1 as a new dependency. However, this change is incomplete as the new dependency has only been added to requirements.txt and is missing from pyproject.toml. This inconsistency can lead to build failures and should be addressed by adding the dependency to pyproject.toml as well.

@frankie-ys frankie-ys closed this Dec 15, 2025
@frankie-ys frankie-ys changed the title Add the requirement which Add the requirement of arctic-inference which speculative decoding with suffix_decode Dec 15, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant