[Xlite][Feature] Xlite support glm4.7 w8a8 quantization#9415
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
a6b71d8 to
67eb1a9
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables w8a8 quantization support for the GLM-4.7 model within the xlite acceleration framework for Ascend NPUs. The changes focus on refactoring the weight initialization logic into a reusable helper method, which simplifies the integration of new model architectures and improves maintainability of the quantization pipelines. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors weight initialization in the xlite module by introducing the init_matmul_weights helper and rgetattr utility, which simplifies quantization parameter handling for Llama and Qwen MoE models. Feedback focuses on optimizing performance by eliminating redundant attribute lookups and function calls within list comprehensions using the walrus operator. Additionally, the reviewer recommends unifying the new attribute traversal utility with existing ones to reduce redundancy and suggests following the repository's specific style guide for the PR title and summary.
9f997f8 to
67e0cc1
Compare
e83654f to
1722c77
Compare
Signed-off-by: wangxiaoran <wangxiaoran11@huawei.com>
What this PR does / why we need it?
This PR adds support for w8a8 quantization of the GLM-4.7 model to the xlite module. Specifically, it introduces shared expert weight processing and refactors the w8a8 weights of xlite, making subsequent adaptation easier.
GLM-4.7-W8A8-floatmtp TPS 910B3(A2) Online Inference Performance Comparison
Does this PR introduce any user-facing change?
Yes, it enables Xlite acceleration for GLM-4.7 model in w8a8 quantization mode on Ascend NPUs.
How was this patch tested?