[CI] Modify nightly test case configuration#9463
Conversation
Signed-off-by: chen-commits <1636718796@qq.com> Signed-off-by: chen <1636718796@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the nightly end-to-end test configurations for the Qwen3-235B model series. By adjusting the compilation settings, specifically targeting CUDA graph modes, the changes aim to improve the stability and performance metrics captured during automated nightly testing cycles. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the nightly test configurations for the Qwen3-235B model by adding compilation configurations for different execution modes. The reviewer identified that the value "FULL_DECODE_ONLY" is likely incorrect and should be replaced with "FULL" to match the expected enum. Additionally, a conflict was noted in one configuration where the --enforce-eager flag would disable the intended graph capturing. Suggestions were also provided to update the PR title and summary according to the repository's style guide.
| --trust-remote-code | ||
| --gpu-memory-utilization 0.9 | ||
| --async-scheduling | ||
| --compilation-config '{"cudagraph_mode":"FULL_DECODE_ONLY"}' |
There was a problem hiding this comment.
Suggested PR Title:
[CI][Misc] Modify nightly test case configuration for Qwen3-235BSuggested PR Summary:
### What this PR does / why we need it?
This PR updates the nightly test configurations for the Qwen3-235B model by adding specific compilation configurations (`cudagraph_mode`). This ensures that the nightly tests cover different execution modes (FULL and PIECEWISE) for better performance and stability validation on Ascend NPUs.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This is a configuration change for nightly tests.References
- The PR title and summary must follow the specified format and be provided in markdown code blocks. (link)
| --trust-remote-code | ||
| --gpu-memory-utilization 0.9 | ||
| --async-scheduling | ||
| --compilation-config '{"cudagraph_mode":"FULL_DECODE_ONLY"}' |
There was a problem hiding this comment.
The cudagraph_mode value "FULL_DECODE_ONLY" appears to be incorrect. The CUDAGraphMode enum (referenced in vllm_ascend/compilation/acl_graph.py) typically supports "FULL" or "PIECEWISE". Using an unsupported string will likely cause a configuration error or skip graph capture entirely. Please use "FULL" if full graph capture is intended.
--compilation-config '{"cudagraph_mode":"FULL"}'| --trust-remote-code | ||
| --gpu-memory-utilization 0.9 | ||
| --async-scheduling | ||
| --compilation-config '{"cudagraph_mode":"FULL_DECODE_ONLY"}' |
There was a problem hiding this comment.
The cudagraph_mode value "FULL_DECODE_ONLY" should be changed to "FULL" to match the expected CUDAGraphMode enum values.
--compilation-config '{"cudagraph_mode":"FULL"}'| --trust-remote-code | ||
| --no-enable-prefix-caching | ||
| --gpu-memory-utilization 0.9 | ||
| --compilation-config '{"cudagraph_mode":"FULL_DECODE_ONLY"}' |
There was a problem hiding this comment.
This server command includes --enforce-eager (line 32), which explicitly disables graph capturing. Adding --compilation-config with a cudagraph_mode here is contradictory and will have no effect. If the goal is to test ACL graphs for this component, --enforce-eager should be removed. Additionally, "FULL_DECODE_ONLY" should be corrected to "FULL".
--compilation-config '{"cudagraph_mode":"FULL"}'| --trust-remote-code | ||
| --no-enable-prefix-caching | ||
| --gpu-memory-utilization 0.9 | ||
| --compilation-config '{"cudagraph_mode":"FULL_DECODE_ONLY"}' |
There was a problem hiding this comment.
The cudagraph_mode value "FULL_DECODE_ONLY" should be changed to "FULL" to match the expected CUDAGraphMode enum values.
--compilation-config '{"cudagraph_mode":"FULL"}'
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 participant
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?