Pin vLLM core version to VLLM_GAUDI_COMMIT in RHEL UBI Dockerfile - #1571
Open
ghandoura wants to merge 3 commits into
Open
Pin vLLM core version to VLLM_GAUDI_COMMIT in RHEL UBI Dockerfile#1571ghandoura wants to merge 3 commits into
ghandoura wants to merge 3 commits into
Conversation
When VLLM_GAUDI_COMMIT is a release tag, set SETUPTOOLS_SCM_PRETEND_VERSION during the vLLM core install so `vllm --version` reports the vllm-gaudi release version (e.g. 0.19.1.post1) instead of the upstream core version with the +empty local segment (e.g. 0.19.1+empty). The override is skipped when VLLM_GAUDI_COMMIT=main to preserve setuptools_scm's git-derived version for dev builds. Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com>
ghandoura
requested review from
PatrykWo,
adobrzyn,
afierka-intel,
iboiko-habana,
jbyczkow,
mgawarkiewicz-intel,
michalkuligowski and
xuechendi
as code owners
June 26, 2026 15:30
ghandoura
had a problem deploying
to
pre-merge-approval
June 26, 2026 15:30 — with 
GitHub Actions
Error
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the RHEL UBI build flow so that when installing the upstream vLLM core from source, the resulting installed package version can be overridden to reflect the vllm-gaudi release tag (via SETUPTOOLS_SCM_PRETEND_VERSION) instead of the upstream git-derived +empty local version segment.
Changes:
- Adds logic in the RHEL UBI Dockerfile to set
SETUPTOOLS_SCM_PRETEND_VERSIONbased onVLLM_GAUDI_COMMITwhen it is intended to represent a release tag. - Ensures the version override is skipped for
VLLM_GAUDI_COMMIT=main(dev builds) per the PR description intent.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com>
ghandoura
had a problem deploying
to
pre-merge-approval
June 26, 2026 15:34 — with
GitHub Actions
Error
GitHub Actions
Error
Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com>
ghandoura
had a problem deploying
to
pre-merge-approval
June 26, 2026 15:37 — with
GitHub Actions
Error
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When VLLM_GAUDI_COMMIT is a release tag, set SETUPTOOLS_SCM_PRETEND_VERSION during the vLLM core install so
vllm --versionreports the vllm-gaudi release version (e.g. 0.19.1.post1) instead of the upstream core version with the +empty local segment (e.g. 0.19.1+empty).The override is skipped when VLLM_GAUDI_COMMIT=main to preserve setuptools_scm's git-derived version for dev builds.