Skip to content

[kimi2.6] enable model text only initial - #1574

Open
sureshnam wants to merge 1 commit into
vllm-project:mainfrom
sureshnam:kimi_k26
Open

[kimi2.6] enable model text only initial#1574
sureshnam wants to merge 1 commit into
vllm-project:mainfrom
sureshnam:kimi_k26

Conversation

@sureshnam

Copy link
Copy Markdown
Collaborator

Adds VLLM_SKIP_MM_WARMUP=1 to skip only the multimodal-graph warm-up while still running the prompt and decode graph warm-up.

Motivation: some multimodal models include vision towers whose upstream implementation hits a torch._inductor code path that has no 'hpu' backend registered, causing engine init to crash in warmup_multimodal_graphs. Today the only workaround is VLLM_SKIP_WARMUP, which disables all warmup and causes runtime JIT-compile stalls on every new bucket size hit. With this knob, users running such models text-only can keep the normal prompt/decode bucket warmup and avoid the runtime stalls, while skipping just the vision compile that they don't need.

Pattern follows existing in-file env-var gates such as VLLM_SKIP_MARK_UNBACKED. Documents the new variable under Developer Mode Parameters next to VLLM_SKIP_WARMUP.

Adds VLLM_SKIP_MM_WARMUP=1 to skip only the multimodal-graph warm-up while
still running the prompt and decode graph warm-up.

Motivation: some multimodal models include vision towers whose upstream
implementation hits a torch._inductor code path that has no 'hpu' backend
registered, causing engine init to crash in warmup_multimodal_graphs.
Today the only workaround is VLLM_SKIP_WARMUP, which disables all warmup
and causes runtime JIT-compile stalls on every new bucket size hit. With
this knob, users running such models text-only can keep the normal
prompt/decode bucket warmup and avoid the runtime stalls, while skipping
just the vision compile that they don't need.

Pattern follows existing in-file env-var gates such as
VLLM_SKIP_MARK_UNBACKED. Documents the new variable under Developer Mode
Parameters next to VLLM_SKIP_WARMUP.

Signed-off-by: Suresh Nampalli <suresh.b.nampalli@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new env var gate to selectively skip multimodal (vision) warmup graph compilation on Gaudi, allowing text-only usage of multimodal models to keep prompt/decode warmup (and avoid runtime JIT stalls) while bypassing vision tower compilation failures.

Changes:

  • Add VLLM_SKIP_MM_WARMUP handling in HPUModelRunner.warmup_model() to skip warmup_multimodal_graphs() while preserving prompt/decode warmup.
  • Add documentation for VLLM_SKIP_MM_WARMUP under Developer Mode parameters.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
vllm_gaudi/v1/worker/hpu_model_runner.py Adds an env-var gate to skip only multimodal warmup graphs in both lazy-mode and torch.compile warmup flows.
docs/configuration/env_variables.md Documents the new VLLM_SKIP_MM_WARMUP variable next to VLLM_SKIP_WARMUP.

# uses a torch._inductor path without an 'hpu' backend), and when the
# user is running the model text-only and does not need the vision
# path. Differs from VLLM_SKIP_WARMUP, which disables all warmup.
skip_mm_warmup = os.environ.get('VLLM_SKIP_MM_WARMUP', '0').lower() in ('1', 'true')
# uses a torch._inductor path without an 'hpu' backend), and when the
# user is running the model text-only and does not need the vision
# path. Differs from VLLM_SKIP_WARMUP, which disables all warmup.
skip_mm_warmup = os.environ.get('VLLM_SKIP_MM_WARMUP', '0').lower() in ('1', 'true')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add it to features and use get_config?

@iboiko-habana

Copy link
Copy Markdown
Collaborator

@sureshnam do we need this PR or it can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants