Port of: Handle None attn_bias in FusedSDPA tiling path- #1778 - #1784
Open
iboiko-habana wants to merge 1 commit into
Open
Port of: Handle None attn_bias in FusedSDPA tiling path- #1778#1784iboiko-habana wants to merge 1 commit into
iboiko-habana wants to merge 1 commit into
Conversation
Signed-off-by: Iryna Boiko <iboiko@habana.ai>
iboiko-habana
requested review from
PatrykWo,
adobrzyn,
afierka-intel,
jbyczkow,
mgawarkiewicz-intel,
michalkuligowski and
xuechendi
as code owners
September 7, 2026 09:25
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates the FusedSDPA q-tiling conditional to explicitly avoid entering the tiling path when attn_bias is None.
Changes:
- Adds an explanatory comment about why tiling is unnecessary without a bias plane.
- Expands the branching condition to treat
attn_bias is Noneas a no-tiling case.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+484
to
+485
| # Without a bias there is no plane to tile; _fsdpa_num_q_tiles already returns 1 for that case. | ||
| if attn_bias is None or num_q_tiles == 1: |
pawel-olejniczak
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.