Add UCF101 dataset support for multi-modal benchmark#1210
Add UCF101 dataset support for multi-modal benchmark#1210futurenitian wants to merge 3 commits intovllm-project:mainfrom
Conversation
Add support for 'hf' dataset in input request sampling. Signed-off-by: future <3172516720@qq.com>
Signed-off-by: future <3172516720@qq.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3007854fd3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| elif args.dataset_name == "hf": | ||
| if not args.dataset_path: | ||
| raise ValueError("dataset_path must be specified for ucf101-subset dataset.") | ||
| dataset = UCF101MultiModalDataset( |
There was a problem hiding this comment.
Add missing import for UCF101MultiModalDataset
When args.dataset_name == "hf" this branch constructs UCF101MultiModalDataset, but patch.py never imports that symbol, so the benchmark will raise NameError at runtime as soon as the branch is hit. This makes the new dataset path unusable in the openai-chat-omni flow until the class is imported from vllm_omni.benchmarks.data_modules.ucf101_multi_modal_dataset.
Useful? React with 👍 / 👎.
| return { | ||
| "type": "video_url", | ||
| "video_url": {"url": f"data:video/mp4;base64,{video_base64}"}, |
There was a problem hiding this comment.
Fix MIME type for .avi videos in data URLs
UCF101 includes many .avi files, and load_ucf101_subset explicitly allows .avi, but process_ucf101_video always emits data:video/mp4;base64,.... When the selected file is AVI, downstream clients that rely on the MIME header can fail to decode or mis-handle the payload. The MIME type should be derived from the file extension (e.g., video/x-msvideo for .avi) to avoid decoding errors for the default UCF101 files.
Useful? React with 👍 / 👎.
Signed-off-by: future <3172516720@qq.com>
This PR follows the RFC #752
Purpose
Add support for UCF101 dataset in multi-modal benchmark
File Structure
Core Benchmark Module (vllm_omni/benchmarks/)
Test Plan
Test command
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)