[Version] Auto generate version using setuptool_scm#1224
Open
tjtanaa wants to merge 4 commits intovllm-project:mainfrom
Open
[Version] Auto generate version using setuptool_scm#1224tjtanaa wants to merge 4 commits intovllm-project:mainfrom
setuptool_scm#1224tjtanaa wants to merge 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 234d889b96
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This PR uses
setuptool_scmto auto generate version tag based on the github release tag.Following upstream, the vllm-omni version will also contains platform tag e.g.
For release version
For Dev version
Following vLLM, this PR also includes the feature to override the version
VLLM_OMNI_VERSION_OVERRIDE. However, if developer usesVLLM_OMNI_VERSION_OVERRIDE, platform tag will not automatically be appended. E.g.VLLM_OMNI_VERSION_OVERRIDE=0.16.0 pip install -e ., the version you get isvllm-omni==0.16.0, notvllm-omni==0.16.0+cudaRetaining the convention set in vLLM repo,
SETUPTOOLS_SCM_PRETEND_VERSIONis not exposed directly.Test Plan
Tested with the following command:
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)