[Bugfix] Fix 'NoneType' AttributeError in stable-diffusion model detect#1254
[Bugfix] Fix 'NoneType' AttributeError in stable-diffusion model detect#1254yma11 wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Yan Ma <yan.ma@intel.com>
|
@princepride PTAL |
|
@yma11 Thanks for your contribute, lgtm, Did you encounter this error while using this model: |
Yes. This model will pop error: But I think this is an model issue that it's lack of necessary model config info. We need to make some work around for this model specifically. Will it make sense? if so, I can do it in another PR. |
I believe that if this file is necessary, the best approach is to let sd provide the correct config.json file. We don't need to do any special adaptation for this incorrect model file. |
Agree. |
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This PR is to fix
NoneTypeattribute error which happens in diffusion model config parsing.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)