Skip to content

Add support for mistral3 (no vision encoding) #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alex-jw-brooks wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Draft

Add support for mistral3 (no vision encoding) #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vllm_spyre/model_executor/model_loader/spyre.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ def __init__(
elif self.config.model_type == "gpt_bigcode":
self.kv_cache_specs["num_layers"] = self.config.n_layer
self.kv_cache_specs["head_dim"] = self.config.n_embd // self.config.n_head
elif self.config.model_type == "pixtral":
self.kv_cache_specs["num_layers"] = self.config.text_config.num_hidden_layers
self.kv_cache_specs["head_dim"] = self.config.text_config.head_dim
else:
raise NotImplementedError(
f"[SpyreCausalLM] model type {self.config.model_type} "
Expand Down
6 changes: 6 additions & 0 deletions vllm_spyre/v1/worker/spyre_model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,12 @@ def build_input_batch(self) -> SamplingInputBatch:

@property
def vocab_size(self) -> int:
cfg = self.model.model.model.config
# Mistral3 MM models, which currently only run text;
# TODO (Alex) move this to utils after granite vision
# is merged.
if hasattr(cfg, "text_config"):
return cfg.text_config.src_vocab_size
Copy link
Collaborator

@gkumbhat gkumbhat Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: next line can be modified to be cfg.src_vocab_size

return self.model.model.model.config.src_vocab_size

def pad_input_ids(
Expand Down