Skip to content

🔥 Remove all continuous batching tests#693

Open
joerunde wants to merge 17 commits into2.0-release-prepfrom
rip-out-cb
Open

🔥 Remove all continuous batching tests#693
joerunde wants to merge 17 commits into2.0-release-prepfrom
rip-out-cb

Conversation

@joerunde
Copy link
Collaborator

@joerunde joerunde commented Feb 5, 2026

Description

Starting on #679, working on deleting all of the CB tests and refactoring the cases that were only written for CB to run with CP instead.

Leaving this PR as test-only changes to limit the diff. We can work separately on actually removing all the CB related code.

Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
repo: "git+https://github.com/vllm-project/vllm --branch main"
test_suite:
- name: "chunked prefill"
markers: "cpu and chunked_prefill and not prefix_caching and not quantized and not multimodal"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chunked_prefill mark still exists, but I don't think it'll make sense to keep maintaining since every decoder test will be using chunked prefill.

We could clean up mode: str with these marks to something like disable_prefix_caching: bool. I think that'd make sense to do once we swap the default behavior to using prefix caching, then we can selectively disable for some tests where required.

Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
@joerunde joerunde changed the title [WIP] Remove all continuous batching tests 🔥 Remove all continuous batching tests Feb 5, 2026
Signed-off-by: Joe Runde <joe@joerun.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant