Skip to content

Conversation

@jikunshang
Copy link
Collaborator

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.

Purpose

clean up docker image in ci, avoid disk full.

Test Plan

Test Result

(Optional) Documentation Update

BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Kunshang Ji <[email protected]>
Copilot AI review requested due to automatic review settings December 15, 2025 05:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Docker cleanup commands to the CI workflow to prevent disk space exhaustion. The changes ensure that Docker images and unused resources are removed after test runs complete.

  • Adds explicit Docker image removal commands for the test container
  • Includes Docker system prune to clean up dangling resources

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

run: |
docker rm -f vllm-xpu-kernel-ci || true
docker image rm -f vllm-xpu-kernel-ci || true;
docker system prune -f || true;
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing semicolons on these lines. In shell scripts, semicolons are statement terminators and are unnecessary at the end of a line. The other commands in this workflow (e.g., line 40 and 74) do not use trailing semicolons, making these inconsistent with the existing style.

Suggested change
docker system prune -f || true;
docker system prune -f || true

Copilot uses AI. Check for mistakes.
run: |
docker rm -f vllm-xpu-kernel-ci || true
docker image rm -f vllm-xpu-kernel-ci || true;
docker system prune -f || true;
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing semicolons on these lines. In shell scripts, semicolons are statement terminators and are unnecessary at the end of a line. The other commands in this workflow (e.g., line 40 and 74) do not use trailing semicolons, making these inconsistent with the existing style.

Suggested change
docker system prune -f || true;
docker system prune -f || true

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant