Skip to content

fix: fix engine initialization fails with ValueError #30645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leejianwoo-collab wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix: fix engine initialization fails with ValueError #30645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
848aca9
fix: fix engine initialization fails with ValueError
leejianwoo-collab Dec 14, 2025
63a1ad1
Update vllm/model_executor/models/glm4_1v.py
leejianwoo-collab Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vllm/model_executor/models/glm4_1v.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,7 @@ def get_num_frames_with_most_features(
max_total_frames // max(max_videos, 1), _MAX_FRAMES_PER_VIDEO
)

return max(max_frames_per_video, 1)
return max(max_frames_per_video, 3)

def _get_video_second_idx_glm4v(
self, metadata: dict[str, Any], total_frames: int
Expand Down Expand Up @@ -1844,3 +1844,4 @@ class Glm4vMoeForConditionalGeneration(Glm4vForConditionalGeneration):
"up_proj",
],
}