-
-
Notifications
You must be signed in to change notification settings - Fork 12k
Strengthen input validation and tests for 'parse_raw_prompts’. #30652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mivehk
wants to merge
7
commits into
vllm-project:main
Choose a base branch
from
mivehk:improve-parse-tests-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−12
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4773df8
Added a test for invalid inputs for parse_raw_prompts
mivehk 0ac3b2f
Updated the invalid_input condition for parse_raw_prompt
mivehk c9a523a
Updated parse_raw_promptinput validation tests - uv pre-commit installed
mivehk d9dd01d
Added strict validation for nested array inputs in parse_raw_prompts
mivehk 4c8d1fc
Updated parse_raw_prompt control flow to raise ValueError for empty n…
mivehk 5cc0f4a
Updated nested token validation to avoid expensive asymptotic check
mivehk 87b6406
Added per-prompt validation test for mixed batched prompts
mivehk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,8 +34,8 @@ | |
| ] | ||
|
|
||
|
|
||
| # Test that a nested mixed-type list of lists raises a TypeError. | ||
| @pytest.mark.parametrize("invalid_input", [[[1, 2], ["foo", "bar"]]]) | ||
| # Per-prompt validation: mixed batched raw-string & tokenized prompts raise TypeError. | ||
| @pytest.mark.parametrize("invalid_input", [[["key", "cat"], [2, 3]]]) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just use the original test case? Why does it need to be changed? |
||
| def test_invalid_input_raise_type_error(invalid_input): | ||
| with pytest.raises(TypeError): | ||
| parse_raw_prompts(invalid_input) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.