Skip to content

Conversation

@maxyanghu
Copy link
Contributor

@maxyanghu maxyanghu commented Dec 15, 2025

Purpose

After #29752 enabled Efficient Video Sampling for Qwen3VLForConditionalGeneration model, Qwen3VLMoeForConditionalGeneration model errors out due to newly added configuration is_multimodal_pruning_enabled not initialized and set.

This PR fixes the issue and set the field.

Test Plan

vllm serve RedHatAI/Qwen3-VL-235B-A22B-Instruct-NVFP4 --async-scheduling --max-model-len 32768 --max-num-seqs 1024


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Max Hu <[email protected]>
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify mergify bot added the qwen Related to Qwen models label Dec 15, 2025
@mergify
Copy link

mergify bot commented Dec 15, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @maxyanghu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 15, 2025
Signed-off-by: Max Hu <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug in the Qwen3VLMoeForConditionalGeneration model where the is_multimodal_pruning_enabled attribute was not being initialized. This led to an error when using the model with multimodal configurations that enable video sampling. The change adds the necessary initialization, resolving the issue. The fix is correct and directly addresses the problem described.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for fixing!

@DarkLight1337
Copy link
Member

Can you resolve the merge conflict?

Signed-off-by: Max Hu <[email protected]>
@DarkLight1337
Copy link
Member

There is still a merge conflict

@DarkLight1337 DarkLight1337 added this to the v0.13.0 milestone Dec 15, 2025
@mergify mergify bot removed the needs-rebase label Dec 15, 2025
@maxyanghu
Copy link
Contributor Author

There is still a merge conflict

All conflict should be resolved now. This is a quick fix but I feel like this class needs refactoring. Qwen3VLMoeForConditionalGeneration(sub class) and Qwen3VLForConditionalGeneration (base class) has lots of duplicated code in __init__

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 15, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 15, 2025 11:50
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 15, 2025 11:50
@DarkLight1337 DarkLight1337 merged commit 3f175f1 into vllm-project:main Dec 15, 2025
56 checks passed
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Dec 15, 2025
joa-stdn pushed a commit to joa-stdn/vllm that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nvidia qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants