-
-
Notifications
You must be signed in to change notification settings - Fork 12k
[Bugfix] Fix multimodal configuration for Qwen3VL MOE model #30670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Max Hu <[email protected]>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Max Hu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a bug in the Qwen3VLMoeForConditionalGeneration model where the is_multimodal_pruning_enabled attribute was not being initialized. This led to an error when using the model with multimodal configurations that enable video sampling. The change adds the necessary initialization, resolving the issue. The fix is correct and directly addresses the problem described.
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks for fixing!
|
Can you resolve the merge conflict? |
Signed-off-by: Max Hu <[email protected]>
|
There is still a merge conflict |
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Max Hu <[email protected]>
Signed-off-by: Max Hu <[email protected]>
All conflict should be resolved now. This is a quick fix but I feel like this class needs refactoring. |
…ject#30670) Signed-off-by: Max Hu <[email protected]>
…ject#30670) Signed-off-by: Max Hu <[email protected]> Signed-off-by: Joachim Studnia <[email protected]>
Purpose
After #29752 enabled Efficient Video Sampling for
Qwen3VLForConditionalGenerationmodel,Qwen3VLMoeForConditionalGenerationmodel errors out due to newly added configurationis_multimodal_pruning_enablednot initialized and set.This PR fixes the issue and set the field.
Test Plan
vllm serve RedHatAI/Qwen3-VL-235B-A22B-Instruct-NVFP4 --async-scheduling --max-model-len 32768 --max-num-seqs 1024Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.