Skip to content

Conversation

@pisceskkk
Copy link
Contributor

@pisceskkk pisceskkk commented Dec 15, 2025

Purpose

This PR add unit test for compute_slot_mapping function in block_table.py with various pcp_size & dcp_size & cp_kv_cache_interleave_size.

Test Plan

pytest tests/v1/worker/test_block_table.py

Test Result

==== 17 passed, 1 warning in 2.65s ====

CC @LucasWilkinson @zhangsicheng5 @FENP

Signed-off-by: QiuChunshuo <[email protected]>
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify mergify bot added the v1 label Dec 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds comprehensive unit tests for the compute_slot_mapping function in block_table.py. The tests cover various configurations of PCP, DCP, and KV cache interleave sizes, which is great for ensuring correctness under different parallelism settings. My review focuses on improving the clarity and correctness of the test documentation to prevent future confusion.

Signed-off-by: QiuChunshuo <[email protected]>
Signed-off-by: QiuChunshuo <[email protected]>
@mergify
Copy link

mergify bot commented Dec 15, 2025

Hi @pisceskkk, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant