Skip to content

Conversation

@ILikeIneine
Copy link
Contributor

@ILikeIneine ILikeIneine commented Dec 15, 2025

Purpose

This is a follow-up to #26487.

It accidently change the order of attention registry default parameter, which caused the failure in normal registry and crashed all the workflow of our plugins tests (the vllm-metax).

For not adding class_path = everywhere in the registry code in non-mamba cases ( and I think that's the most common situation) , it is needed to exchange the order of the default parameter.

Test Plan

By plugin

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the parameter order in the register_backend function signature. The previous order caused issues with positional arguments, particularly for direct backend registration. By swapping class_path and is_mamba, this change restores the intended behavior and improves the API's usability for the most common use cases. The change is correct and well-justified. I approve this change.

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to be later in the arg list, thank you

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants