Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Dec 15, 2025

Purpose

Follow-up to #30675 to reduce CI cost

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 15, 2025
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify mergify bot added ci/build deepseek Related to DeepSeek models qwen Related to Qwen models labels Dec 15, 2025
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to move tool parser tests to a CPU-only CI job to reduce costs. The changes involve renaming test files and updating CI configuration. However, there are several issues in the CI configuration files. The paths for the moved test files are incorrect, which will prevent these tests from running. Additionally, some pytest commands seem to be malformed, which could cause CI jobs to fail. I've provided specific comments and suggestions to fix these issues.

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 changed the title [Refactor] [3/N] Move tool parser tests into CPU tests [Refactor] [3/N] Move tool parser tests and run on CPU Dec 15, 2025
@DarkLight1337
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the testing setup for tool parsers to reduce CI costs. The changes involve moving tool parser tests from tests/tool_use to a new tests/tool_parsers directory and configuring them to run on CPU within an existing test job. This correctly consolidates CPU-based tests and frees up GPU resources. The CI configuration files (.buildkite/*.yaml) are updated accordingly, removing the separate CPU test job for tool use and simplifying the GPU test command. The pytest.mark.cpu_test markers have been correctly removed from the moved test files. The changes are logical, consistent, and effectively achieve the goal of optimizing CI resource usage.

Copy link
Collaborator

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@chaunceyjiang chaunceyjiang enabled auto-merge (squash) December 15, 2025 13:24
@chaunceyjiang chaunceyjiang merged commit ed586e7 into vllm-project:main Dec 15, 2025
19 checks passed
@DarkLight1337 DarkLight1337 deleted the mv-tool-use-cpu branch December 15, 2025 13:49
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Dec 15, 2025
joa-stdn pushed a commit to joa-stdn/vllm that referenced this pull request Dec 15, 2025
weiyu0824 pushed a commit to weiyu0824/vllm that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build deepseek Related to DeepSeek models qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants