Revert "[SM100] Enable fp8 compute for prefill MLA (#30746)"#31197
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Dec 23, 2025
Merged
Revert "[SM100] Enable fp8 compute for prefill MLA (#30746)"#31197vllm-bot merged 1 commit intovllm-project:mainfrom
vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
This reverts commit b10f41c. Signed-off-by: Pavani Majety <pmajety@nvidia.com>
pavanimajety
requested review from
mgoin,
robertgshaw2-redhat,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly reverts the changes from commit b10f41c894bc..., which introduced fp8 compute for prefill MLA. The changes are consistent across the modified files, removing fp8-related logic and parameters from vllm/v1/attention/backends/mla/common.py and reverting test configurations in tests/v1/attention/test_mla_backends.py. A minor change in vllm/model_executor/layers/quantization/utils/flashinfer_fp4_moe.py appears to be a necessary API adaptation. The revert appears to be clean and achieves its stated purpose of temporarily disabling the feature. I have not found any issues of high or critical severity.
3 tasks
mgoin
approved these changes
Dec 23, 2025
Member
|
Thanks @pavanimajety |
5 tasks
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
…" (vllm-project#31197) Signed-off-by: Pavani Majety <pmajety@nvidia.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b10f41c.
Purpose
Revert #30746 untill #30993 is merged.
Test Plan
Regular CI
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.