[Doc] Enhance documentation around CPU container images#32286
[Doc] Enhance documentation around CPU container images#32286bigPYJ1151 merged 1 commit intovllm-project:mainfrom
Conversation
|
Documentation preview: https://vllm--32286.org.readthedocs.build/en/32286/ |
There was a problem hiding this comment.
Code Review
This pull request enhances the documentation for CPU container images by adding instructions for building a CPU-only image and pulling pre-built CPU images. The changes are clear and helpful. I've found one minor issue in the provided build command example where an irrelevant build argument is mentioned, which could confuse users. I've suggested its removal.
f187f68 to
d4749fa
Compare
fadara01
left a comment
There was a problem hiding this comment.
Great docs improvement!
Please see my comments and add Arm related docs/info where relevant, similar to what you do for x86
d4749fa to
a88b081
Compare
c9013ca to
3de6403
Compare
5d64ef3 to
d999e62
Compare
|
Hi @nathan-weinberg, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
5078146 to
4eb4a86
Compare
fadara01
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment for clarity and my own learning
9b74abb to
3601a9d
Compare
Adds a bit more detail around building and pulling CPU container images Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
3601a9d to
cac2744
Compare
…#32286) Signed-off-by: Nathan Weinberg <nweinber@redhat.com> Signed-off-by: Pai <416932041@qq.com>
…#32286) Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Supercedes #31749
Adds a bit more detail around building and pulling CPU container images
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.