[Tests] Skip model weight download for render-only test server#36813
Open
sagearc wants to merge 4 commits intovllm-project:mainfrom
Open
[Tests] Skip model weight download for render-only test server#36813sagearc wants to merge 4 commits intovllm-project:mainfrom
sagearc wants to merge 4 commits intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the model pre-download logic to allow skipping it for the render-only test server, which is a sensible optimization. However, the new implementation for the render server completely skips any pre-download. Since the render server still requires the tokenizer, this could lead to test flakiness if the server startup times out while downloading it. I've provided a suggestion to explicitly pre-download only the tokenizer for the render server to make the tests more robust.
Contributor
Author
Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
3bfce13 to
4e3d23e
Compare
DarkLight1337
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
RemoteLaunchRenderServerinherits the full model weight download fromRemoteVLLMServer.__init__, but the render server only needs the tokenizer — no weights are loaded at runtime.Changes
_pre_download_modelhook fromRemoteVLLMServer.__init__RemoteLaunchRenderServerTest Plan
Existing render tests (
test_launch_render.py) cover this path.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.