[2/N] Pass model_config to the Attention constructors#38661
Open
MatthewBonanni wants to merge 5 commits intovllm-project:mainfrom
Open
[2/N] Pass model_config to the Attention constructors#38661MatthewBonanni wants to merge 5 commits intovllm-project:mainfrom
model_config to the Attention constructors#38661MatthewBonanni wants to merge 5 commits intovllm-project:mainfrom
Conversation
5 tasks
|
Hi @MatthewBonanni, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the model executor layers and attention mechanisms across various model implementations to explicitly pass the model_config object. It also introduces a mapping from torch.dtype to KV cache string representations in vllm/utils/torch_utils.py to ensure correct cache configuration when cache_config is not provided. I have no further feedback to provide.
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We already pass
cache_configandquant_configas arguments toAttention.__init__(), butmodel_configis routinely grabbed fromget_current_vllm_config. #38124 requires accesssingmodel_config.dtypemuch more frequently, so this PR passesmodel_configas an argument to standardize and reduce reliance onget_current_vllm_config.Test Plan
CI
Test Result
TBD
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.