[CPU] Fix lscpu NUMA node regex to handle quoted - and null in containers#38681
Open
Monokaix wants to merge 1 commit intovllm-project:mainfrom
Open
[CPU] Fix lscpu NUMA node regex to handle quoted - and null in containers#38681Monokaix wants to merge 1 commit intovllm-project:mainfrom
Monokaix wants to merge 1 commit intovllm-project:mainfrom
Conversation
…ners Signed-off-by: Xavier Chang <xuzhengc@nvidia.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the regular expression used to sanitize the JSON output of the lscpu command in vllm/platforms/cpu.py. The modification improves robustness by correctly identifying and replacing various representations of missing NUMA node values, such as "-", -, or null, with a default value of 0 before the string is parsed. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix CPU worker startup crash in Docker containers where NUMA topology is unavailable (e.g., ARM64 on macOS Docker Desktop).
lscpu -J -e=CPU,CORE,NODEoutputs"node": "-"(quoted dash) in these environments, but the existing regex only handled"node": -(unquoted dash). This caused all CPUs to be filtered out inget_allowed_cpu_core_node_list(), resulting in:AssertionError: Not enough allowed NUMA nodes to bind threads of 1 local CPUWorkers. Allowed NUMA nodes are [].
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.