[XPU] [Quant] rename mxfp8_e4m3_quantize and add xpu backend implementation#38682
[XPU] [Quant] rename mxfp8_e4m3_quantize and add xpu backend implementation#38682zufangzhu wants to merge 6 commits intovllm-project:mainfrom
Conversation
zufangzhu
commented
Apr 1, 2026
- Rename mxfp8_e4m3_quantize → flashinfer_mxfp8_e4m3_quantize to make it explicit that this path is implemented via FlashInfer (and avoid ambiguity with other backends).
- Add xpu_mxfp8_quantize as a new custom op for XPU, providing an XPU MXFP8 quantization path.
Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
|
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Code Review
This pull request renames existing MXFP8 quantization functions to be FlashInfer-specific and introduces a new XPU-specific MXFP8 quantization implementation, including a custom operator registration. The review feedback identifies a critical type mismatch in the XPU fake implementation that would break torch.compile, as well as a non-idiomatic null check. Furthermore, the reviewer pointed out that the model executor still hardcodes FlashInfer calls, which will lead to runtime failures on XPU platforms, necessitating a platform-aware dispatch mechanism.
29218f9 to
8f38386
Compare
|
Hi @zufangzhu, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
|
Hi @zufangzhu, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
|
Hi @zufangzhu, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
Hi @zufangzhu, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|