Skip to content

[Quantization] Rename mxfp4 quant layer and oracle to gpt_oss_mxfp4#38683

Open
zyongye wants to merge 1 commit intovllm-project:mainfrom
zyongye:rename/gpt-oss-mxfp4
Open

[Quantization] Rename mxfp4 quant layer and oracle to gpt_oss_mxfp4#38683
zyongye wants to merge 1 commit intovllm-project:mainfrom
zyongye:rename/gpt-oss-mxfp4

Conversation

@zyongye
Copy link
Copy Markdown
Member

@zyongye zyongye commented Apr 1, 2026

Rename the GPT-OSS-specific MXFP4 quantization files and classes to make ownership explicit:

  • oracle/mxfp4.py → oracle/gpt_oss_mxfp4.py; Mxfp4MoeBackend → GptOssMxfp4MoeBackend
  • quantization/mxfp4.py → quantization/gpt_oss_mxfp4.py; Mxfp4Config → GptOssMxfp4Config, Mxfp4MoEMethod → GptOssMxfp4MoEMethod
  • get_name() now returns "gpt_oss_mxfp4"; registry keeps "mxfp4" alias for backward compat with existing model JSON configs
  • Update all importers (compressed_tensors_moe, quark_moe, init, layer.py, gpt_oss.py)

Kernel class names are unchanged.

Purpose

Test Plan

GPT-OSS-12OB gpqa with reasoning effort low

Test Result

test passed


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Rename the GPT-OSS-specific MXFP4 quantization files and classes to
make ownership explicit:

- oracle/mxfp4.py → oracle/gpt_oss_mxfp4.py; Mxfp4MoeBackend → GptOssMxfp4MoeBackend
- quantization/mxfp4.py → quantization/gpt_oss_mxfp4.py; Mxfp4Config → GptOssMxfp4Config, Mxfp4MoEMethod → GptOssMxfp4MoEMethod
- get_name() now returns "gpt_oss_mxfp4"; registry keeps "mxfp4" alias for backward compat with existing model JSON configs
- Update all importers (compressed_tensors_moe, quark_moe, __init__, layer.py, gpt_oss.py)

Kernel class names are unchanged.

Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Yongye Zhu <yongyezhu@meta.com>

Signed-off-by: Yongye Zhu <zyy1102000@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames and namespaces the mxfp4 quantization components to gpt_oss_mxfp4 across the model executor and quantization layers. Key changes include renaming the Mxfp4MoeBackend enum to GptOssMxfp4MoeBackend, updating the quantization configuration and method classes to use the gpt_oss_mxfp4 prefix, and adjusting the gpt_oss model implementation to recognize the new quantization name. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gpt-oss Related to GPT-OSS models

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant