Skip to content

[Renderer] Remove InputPreprocessor#38688

Open
DarkLight1337 wants to merge 4 commits intovllm-project:mainfrom
DarkLight1337:rm-preprocessor
Open

[Renderer] Remove InputPreprocessor#38688
DarkLight1337 wants to merge 4 commits intovllm-project:mainfrom
DarkLight1337:rm-preprocessor

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Apr 1, 2026

Purpose

Now that #28631 has been merged, we can remove support for unprocessed inputs to the AsyncLLM.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from noooop April 1, 2026 04:42
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 1, 2026
@mergify mergify bot added the v1 label Apr 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the InputPreprocessor and associated logic, transitioning the engine to strictly accept pre-processed EngineInput instead of raw PromptType or EngineCoreRequest. It also removes tokenization_kwargs from several core method signatures across protocol.py, async_llm.py, and input_processor.py. Review feedback identifies that the encode method signatures in both the protocol and AsyncLLM were missed during this refactor and still include the deprecated PromptType. Additionally, an internal call within _add_streaming_input_request needs to be updated to provide a valid EngineInput dictionary to avoid runtime errors.

@mergify
Copy link
Copy Markdown

mergify bot commented Apr 1, 2026

Hi @DarkLight1337, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@mergify mergify bot added the frontend label Apr 1, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@mergify mergify bot added the ci/build label Apr 1, 2026
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 1, 2026 05:08
@mergify
Copy link
Copy Markdown

mergify bot commented Apr 1, 2026

Hi @DarkLight1337, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build frontend ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants