Skip to content

[Fix] Align OpenAI vllm_xargs value types across request schemas #48252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sagearc wants to merge 9 commits into
base: main
Choose a base branch
from
+2 −2
Open

[Fix] Align OpenAI vllm_xargs value types across request schemas #48252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f1ba75
fix vllm args drift
sagearc Jul 10, 2026
0cd6343
Replace VLLMXArgs with dict for vllm_xargs
sagearc Jul 10, 2026
0ad0a9b
Change VLLMXArgs to a more flexible dictionary type
sagearc Jul 10, 2026
3466adf
Remove unused type aliases in protocol.py
sagearc Jul 10, 2026
501499a
Update protocol.py
sagearc Jul 10, 2026
c1e5ad0
Merge branch 'main' into align-completion-request-xargs
sagearc Jul 11, 2026
52146ee
Merge branch 'main' into align-completion-request-xargs
sagearc Jul 11, 2026
dc87f5b
Merge branch 'main' into align-completion-request-xargs
sagearc Jul 12, 2026
2e0392c
Merge upstream/main into align-completion-request-xargs
sagearc Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vllm/entrypoints/openai/chat_completion/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
StructuralTagResponseFormat,
ToolCall,
UsageInfo,
VLLMXArgs,
validate_structural_tag_response_format,
validate_structured_outputs_structural_tag,
)
Expand Down Expand Up @@ -439,7 +440,7 @@ class ChatCompletionRequest(OpenAIBaseModel):
description="KVTransfer parameters used for disaggregated serving.",
)

vllm_xargs: dict[str, str | int | float | list[str | int | float]] | None = Field(
vllm_xargs: VLLMXArgs | None = Field(
default=None,
description=(
"Additional request parameters with (list of) string or "
Expand Down
5 changes: 3 additions & 2 deletions vllm/entrypoints/openai/completion/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
StreamOptions,
StructuralTagResponseFormat,
UsageInfo,
VLLMXArgs,
validate_structural_tag_response_format,
validate_structured_outputs_structural_tag,
)
Expand Down Expand Up @@ -186,10 +187,10 @@ class CompletionRequest(OpenAIBaseModel):
description="KVTransfer parameters used for disaggregated serving.",
)

vllm_xargs: dict[str, str | int | float] | None = Field(
vllm_xargs: VLLMXArgs | None = Field(
default=None,
description=(
"Additional request parameters with string or "
"Additional request parameters with (list of) string or "
"numeric values, used by custom extensions."
),
)
Expand Down
3 changes: 3 additions & 0 deletions vllm/entrypoints/openai/engine/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@

logger = init_logger(__name__)

VLLMXArgsValue: TypeAlias = str | int | float | list[str | int | float]
VLLMXArgs: TypeAlias = dict[str, VLLMXArgsValue]


class OpenAIBaseModel(BaseModel):
# OpenAI API does allow extra fields
Expand Down
4 changes: 2 additions & 2 deletions vllm/entrypoints/openai/responses/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
ChatCompletionMessageParam,
ChatTemplateContentFormatOption,
)
from vllm.entrypoints.openai.engine.protocol import OpenAIBaseModel
from vllm.entrypoints.openai.engine.protocol import OpenAIBaseModel, VLLMXArgs
from vllm.exceptions import VLLMValidationError
from vllm.logger import init_logger
from vllm.renderers import ChatParams, TokenizeParams, merge_kwargs
Expand Down Expand Up @@ -265,7 +265,7 @@ class ResponsesRequest(OpenAIBaseModel):
seed: int | None = Field(None, ge=_INT64_MIN, le=_INT64_MAX)
stop: str | list[str] | None = []
ignore_eos: bool = False
vllm_xargs: dict[str, str | int | float | list[str | int | float]] | None = Field(
vllm_xargs: VLLMXArgs | None = Field(
default=None,
description=(
"Additional request parameters with (list of) string or "
Expand Down
Loading