[WIP][Perf][ROCm] Route gfx942 fp8_mqa_logits to AITER's Gluon kernel#48581
Draft
haosdent wants to merge 1 commit into
Draft
[WIP][Perf][ROCm] Route gfx942 fp8_mqa_logits to AITER's Gluon kernel#48581haosdent wants to merge 1 commit into
haosdent wants to merge 1 commit into
Conversation
Follow-up to ROCm/aiter#4232, which adds a native-fp8-MFMA Gluon fp8_mqa_logits kernel for gfx942 (MI300X). Once vLLM's pinned AITER carries it, gfx942 no longer needs the vendored stopgap: - Pin AITER to a commit (git clone + checkout instead of --branch) so we can bump it to the aiter#4232 merge SHA and pull in the gfx942 Gluon kernel. - Drop the _ON_GFX942 short-circuit in rocm_fp8_mqa_logits so gfx942 falls through to the AITER fp8_mqa_logits path, which now dispatches the Gluon kernel on gfx942. - Delete the vendored vllm/v1/attention/ops/triton_fp8_mqa_logits.py. WIP: AITER_COMMIT is a placeholder until aiter#4232 merges; set it to the merge SHA on ROCm/aiter:main before this leaves draft. Signed-off-by: haosdent <haosdent@gmail.com>
haosdent
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to ROCm/aiter#4232, which adds a native-fp8-MFMA Gluon
fp8_mqa_logitsscoring kernel for gfx942 (MI300X). Once vLLM's pinned AITER carries that kernel, gfx942 no longer needs vLLM's vendored stopgap, so this removes it:git clone+git checkoutinstead of--branch) so it can be bumped to the aiter#4232 merge SHA and pull the gfx942 Gluon kernel into the ROCm image._ON_GFX942short-circuit inrocm_fp8_mqa_logitsso gfx942 falls through to the AITERfp8_mqa_logitspath, which now dispatches the Gluon kernel on gfx942.vllm/v1/attention/ops/triton_fp8_mqa_logits.py.Net effect on gfx942: the DSA lightning-indexer scoring kernel runs AITER's native-fp8-MFMA Gluon kernel (1.84x the generic Triton fallback at the GLM-5.2 indexer shape) instead of the
input_precision="ieee"f16-upcast fallback.Test Plan
Test Result