Skip to content

[XPU] upgrade to torch 2.13#48677

Draft
yma11 wants to merge 1 commit into
vllm-project:mainfrom
yma11:torch-213
Draft

[XPU] upgrade to torch 2.13#48677
yma11 wants to merge 1 commit into
vllm-project:mainfrom
yma11:torch-213

Conversation

@yma11

@yma11 yma11 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: Yan Ma <yan.ma@intel.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@yma11 yma11 marked this pull request as draft July 15, 2026 01:43
@mergify mergify Bot added ci/build intel-gpu Related to Intel GPU labels Jul 15, 2026
Comment thread docker/Dockerfile.xpu
Comment on lines +67 to +68
ARG DLE_INSTALLER="intel-deep-learning-essentials-2026.0.0.624_offline.sh"
RUN wget "https://registrationcenter-download.intel.com/akdlm/IRC_NAS/8170208e-86db-4faa-a0d6-1ecf62699574/${DLE_INSTALLER}" && \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Severity: MEDIUM

This PR replaces GPG-signed apt package installation (which had cryptographic integrity verification via signed-by=) with downloading and executing a shell script installer without any hash or signature verification. A compromised CDN or supply-chain attack could inject arbitrary code executed as root during the Docker build.
Helpful? Add 👍 / 👎

💡 Fix Suggestion

Suggestion: Add SHA256 checksum verification after downloading the installer script and before executing it. Define the expected hash as a build argument and use sha256sum -c to verify the downloaded file's integrity. This ensures that a compromised CDN or supply-chain attack cannot inject arbitrary code.

  1. Add an ARG DLE_INSTALLER_SHA256 with the known SHA256 hash of the installer.
  2. After the wget download, add echo "${DLE_INSTALLER_SHA256} ${DLE_INSTALLER}" | sha256sum -c - to verify the hash before executing the script.

To obtain the correct hash, download the installer once and run sha256sum on it, then pin that value.

⚠️ Experimental Feature: This code suggestion is automatically generated. Please review carefully.

Suggested change
ARG DLE_INSTALLER="intel-deep-learning-essentials-2026.0.0.624_offline.sh"
RUN wget "https://registrationcenter-download.intel.com/akdlm/IRC_NAS/8170208e-86db-4faa-a0d6-1ecf62699574/${DLE_INSTALLER}" && \
ARG DLE_INSTALLER="intel-deep-learning-essentials-2026.0.0.624_offline.sh"
ARG DLE_INSTALLER_SHA256="<compute_and_insert_expected_sha256_hash_here>"
RUN wget "https://registrationcenter-download.intel.com/akdlm/IRC_NAS/8170208e-86db-4faa-a0d6-1ecf62699574/${DLE_INSTALLER}" && \
echo "${DLE_INSTALLER_SHA256} ${DLE_INSTALLER}" | sha256sum -c - && \

Comment thread docker/Dockerfile.xpu
RUN wget -O- https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB | gpg --dearmor | tee /usr/share/keyrings/oneapi-archive-keyring.gpg > /dev/null && \
echo "deb [signed-by=/usr/share/keyrings/oneapi-archive-keyring.gpg] https://apt.repos.intel.com/oneapi all main" | tee /etc/apt/sources.list.d/oneAPI.list && \
# Install DLE packages
ARG DLE_INSTALLER="intel-deep-learning-essentials-2026.0.0.624_offline.sh"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should not install this. maybe what we need is source umf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build intel-gpu Related to Intel GPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants