[XPU] upgrade to torch 2.13#48677
Conversation
Signed-off-by: Yan Ma <yan.ma@intel.com>
| ARG DLE_INSTALLER="intel-deep-learning-essentials-2026.0.0.624_offline.sh" | ||
| RUN wget "https://registrationcenter-download.intel.com/akdlm/IRC_NAS/8170208e-86db-4faa-a0d6-1ecf62699574/${DLE_INSTALLER}" && \ |
There was a problem hiding this comment.
🟡 Severity: MEDIUM
This PR replaces GPG-signed apt package installation (which had cryptographic integrity verification via signed-by=) with downloading and executing a shell script installer without any hash or signature verification. A compromised CDN or supply-chain attack could inject arbitrary code executed as root during the Docker build.
Helpful? Add 👍 / 👎
💡 Fix Suggestion
Suggestion: Add SHA256 checksum verification after downloading the installer script and before executing it. Define the expected hash as a build argument and use sha256sum -c to verify the downloaded file's integrity. This ensures that a compromised CDN or supply-chain attack cannot inject arbitrary code.
- Add an
ARG DLE_INSTALLER_SHA256with the known SHA256 hash of the installer. - After the
wgetdownload, addecho "${DLE_INSTALLER_SHA256} ${DLE_INSTALLER}" | sha256sum -c -to verify the hash before executing the script.
To obtain the correct hash, download the installer once and run sha256sum on it, then pin that value.
⚠️ Experimental Feature: This code suggestion is automatically generated. Please review carefully.
| ARG DLE_INSTALLER="intel-deep-learning-essentials-2026.0.0.624_offline.sh" | |
| RUN wget "https://registrationcenter-download.intel.com/akdlm/IRC_NAS/8170208e-86db-4faa-a0d6-1ecf62699574/${DLE_INSTALLER}" && \ | |
| ARG DLE_INSTALLER="intel-deep-learning-essentials-2026.0.0.624_offline.sh" | |
| ARG DLE_INSTALLER_SHA256="<compute_and_insert_expected_sha256_hash_here>" | |
| RUN wget "https://registrationcenter-download.intel.com/akdlm/IRC_NAS/8170208e-86db-4faa-a0d6-1ecf62699574/${DLE_INSTALLER}" && \ | |
| echo "${DLE_INSTALLER_SHA256} ${DLE_INSTALLER}" | sha256sum -c - && \ |
| RUN wget -O- https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB | gpg --dearmor | tee /usr/share/keyrings/oneapi-archive-keyring.gpg > /dev/null && \ | ||
| echo "deb [signed-by=/usr/share/keyrings/oneapi-archive-keyring.gpg] https://apt.repos.intel.com/oneapi all main" | tee /etc/apt/sources.list.d/oneAPI.list && \ | ||
| # Install DLE packages | ||
| ARG DLE_INSTALLER="intel-deep-learning-essentials-2026.0.0.624_offline.sh" |
There was a problem hiding this comment.
I feel we should not install this. maybe what we need is source umf
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.